Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail if codecov fails #302

Merged
merged 2 commits into from
May 21, 2024
Merged

Do not fail if codecov fails #302

merged 2 commits into from
May 21, 2024

Conversation

ViralBShah
Copy link
Member

We have the codecov token set up correctly, but this is still causing CI to fail. Don't gate PRs being green on codecov.

We have the codecov token set up correctly, but this is still causing CI to fail. Don't gate PRs being green on codecov.
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.45%. Comparing base (cb485f0) to head (38d4239).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
- Coverage   76.05%   73.45%   -2.60%     
==========================================
  Files           5        5              
  Lines         568      535      -33     
==========================================
- Hits          432      393      -39     
- Misses        136      142       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ararslan ararslan merged commit 9b330c6 into master May 21, 2024
48 of 49 checks passed
@ararslan ararslan deleted the vs/codecov-fail branch May 21, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants